[PM-13450] Admin: Display Multi-organization Enterprise attributes on provider details #4955
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4955 +/- ##
=======================================
Coverage ? 42.55%
=======================================
Files ? 1389
Lines ? 64717
Branches ? 5938
=======================================
Hits ? 27539
Misses ? 35959
Partials ? 1219 ☔ View full report in Codecov by Sentry. |
…terprise-attributes-on-provider-details
bitwarden_license/src/Commercial.Core/Billing/ProviderBillingService.cs
Outdated
Show resolved
Hide resolved
…anization-Enterprise-attributes-on-provider-details' into PM-13450-Admin-Display-Multi-organization-Enterprise-attributes-on-provider-details
…anization-Enterprise-attributes-on-provider-details' into PM-13450-Admin-Display-Multi-organization-Enterprise-attributes-on-provider-details
| Provider provider, | ||
| int enterpriseSeatMinimum, | ||
| int teamsSeatMinimum) | ||
| public async Task ChangePlan(ChangeProviderPlanCommand command) |
There was a problem hiding this comment.
❓ Looks like this is called in one place where we already have access to both the Provider and the ProviderPlan. Could we just include those in the command rather than double fetch them from the DB?
There was a problem hiding this comment.
I just have to check if I can refactor the duplicate call to retrieve provider plans further at this point
bitwarden_license/src/Commercial.Core/Billing/ProviderBillingService.cs
Outdated
Show resolved
Hide resolved
|
|
||
| var teamsProviderPlan = | ||
| providerPlans.Single(providerPlan => providerPlan.PlanType == PlanType.TeamsMonthly); | ||
| public async Task UpdateSeatMinimums(UpdateProviderSeatMinimumsCommand command) |
There was a problem hiding this comment.
❓ Same question as above with regard to this command.
bitwarden_license/src/Commercial.Core/Billing/ProviderBillingService.cs
Outdated
Show resolved
Hide resolved
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13450
📔 Objective
Allow editing multi-organization enterprises in the 'Admin' application.
Allow changing properties:
If both configuration values are changed at the same time the changes happen in the following order:
By making updates to providers or provider plans more atomical, we'd be able to re-use any existing code for other new types of providers as well as reduce the code complexity.
📸 Screenshots
Scenario 1: Changing from Annual & 19 min seats to Monthly & 21 min seats:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes